Re: pgsql/src/interfaces/libpq (Makefile) - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql/src/interfaces/libpq (Makefile)
Date
Msg-id 1575.972172618@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql/src/interfaces/libpq (Makefile)  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-committers
Peter Eisentraut <peter_e@gmx.net> writes:
> (One might wonder why bother about this:  it's because users might try to
> run, e.g., "make all CFLAGS=-O99 -mfoo" etc., so you have to forcibly hold
> on to the necessary CFLAGS as well.  Yeah, I know, COPT -- but who's ever
> heard of that?)

That's a fairly unconvincing example, since the likely result would be
settings CFLAGS to "-O99 ... -O2 ...", thus preventing the user from
getting what he wants.  Given that we do not know how "override" really
behaves (except that it's not like the manual), nor how consistently
it behaves across different versions of gmake, I think that it would be
far smarter to avoid "override" completely.

            regards, tom lane

pgsql-committers by date:

Previous
From: Peter Eisentraut - PostgreSQL
Date:
Subject: pgsql/src/template (aix beos bsdi dgux freebsd hpux irix5 linux netbsd openbsd osf qnx4 sco solaris sunos4 svr4 ultrix4 univel unixware win)
Next
From: Bruce Momjian - CVS
Date:
Subject: pgsql/src/backend/catalog (catalog.c)