Re: pgsql/src/backend/storage/smgr (md.c) - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql/src/backend/storage/smgr (md.c)
Date
Msg-id 157.963238553@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql/src/backend/storage/smgr (md.c)  (The Hermit Hacker <scrappy@hub.org>)
Responses Re: pgsql/src/backend/storage/smgr (md.c)  (The Hermit Hacker <scrappy@hub.org>)
List pgsql-committers
The Hermit Hacker <scrappy@hub.org> writes:
> a few questions:

> 1. back patchable to v7.0.x tree?

Yes, if you think it's worth the trouble.  We don't see that many
trouble reports about it.  (The reason I fixed it just now is that
I was having too many occurrences of the misbehavior due to bugs in
my memory management stuff ;-).)

> 2. worth building a v7.0.3 release for?

I doubt it.

> 3. unless it already does so, might it be an idea to generate a warning
>    or some such in the logs, with the "cause of the request"?

It logs the bogus block number, which is all that md.c knows ...

>> Prevent creating a boatload of empty segments when md.c is asked to
>> access a ridiculously large block number within a relation.

            regards, tom lane

pgsql-committers by date:

Previous
From: The Hermit Hacker
Date:
Subject: Re: pgsql/src/backend/storage/smgr (md.c)
Next
From: The Hermit Hacker
Date:
Subject: Re: pgsql/src/backend/storage/smgr (md.c)