Postgres Pro
Downloads
Home   >   mailing lists

Re: heap_tuple_needs_freeze false positive - Mailing list pgsql-hackers

From Tom Lane
Subject Re: heap_tuple_needs_freeze false positive
Date
Msg-id 15676.1328155426@sss.pgh.pa.us
Whole thread Raw
In response to heap_tuple_needs_freeze false positive  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Tree view 
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> !     if (!(tuple->t_infomask & HEAP_XMAX_INVALID))
>       {
> !         if (!(tuple->t_infomask & HEAP_XMAX_IS_MULTI))

How about just one test,
if (!(tuple->t_infomask & (HEAP_XMAX_INVALID | HEAP_XMAX_IS_MULTI)))

But other than that quibble, yeah, it's a bug.  XMAX_INVALID means just
that: the xmax is not to be thought valid.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: spgist text_ops and LIKE
Next
From: Alvaro Herrera
Date:
Subject: freezing multixacts