Re: pgsql: Remove byte-masking macros for Datum conversion macros - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Remove byte-masking macros for Datum conversion macros
Date
Msg-id 15659.1517583152@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Remove byte-masking macros for Datum conversion macros  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-committers
Peter Eisentraut <peter_e@gmx.net> writes:
> Remove byte-masking macros for Datum conversion macros

Looking at the code now, I think there's at least one bad outcome of
this change: the behavior of CharGetDatum() is now ill-defined, because
we'll (probably) get different results on signed-char and unsigned-char
compilers.  I think we'd be well advised to make that macro be

#define CharGetDatum(X) ((Datum) ((unsigned char) (X)))

            regards, tom lane


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Refactor code for partition bound searching
Next
From: Robert Haas
Date:
Subject: pgsql: Support parallel btree index builds.