Re: pgsql: Use new overflow aware integer operations. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Use new overflow aware integer operations.
Date
Msg-id 15638.1518647798@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Use new overflow aware integer operations.  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Use new overflow aware integer operations.
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
>> Yea, that works for me. I wonder if we should choose an absurd sentinel
>> value to prevent code from relying on one? 0x0000beef or such. Unless
>> somebody protests soon-ish I'll make it so.

> Pushed that way (with 0x5EED as the value, seems more appropriate ;)).

LGTM, thanks!

> I can't convince any of my compilers to actual emit warnings in this
> case, so we'll have to see whether prairiedog like this...

Per my results yesterday, locust and coypu were also complaining;
one of them might come back quicker.

            regards, tom lane


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Use new overflow aware integer operations.
Next
From: Tom Lane
Date:
Subject: pgsql: Stabilize new plpgsql_record regression tests.