Re: pgcrypto: Makefile check - Mailing list pgsql-patches

From Tom Lane
Subject Re: pgcrypto: Makefile check
Date
Msg-id 15633.1101138381@sss.pgh.pa.us
Whole thread Raw
In response to pgcrypto: Makefile check  (Neil Conway <neilc@samurai.com>)
Responses Re: pgcrypto: Makefile check
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> This patch makes the pgcrypto Makefile check that a recognized random
> source has been defined. If no such source is defined, pgcrypto will
> compile successfully but will be unusable.

Oh?

> +$(error "Unrecognized random source: $(random)")

Doesn't look like a successful compile to me.  What's worse, this would
also cause maintenance operations (like "make clean") to fail.

(I see little point in this anyway given that the makefile defaults to
"random = silly" further up.)

            regards, tom lane

pgsql-patches by date:

Previous
From: Troels Arvin
Date:
Subject: Re: SQL Conformance introductory section
Next
From: Andreas Pflug
Date:
Subject: htmlhelp generation