Re: charset / postmaster doc improv - Mailing list pgsql-patches

From Tom Lane
Subject Re: charset / postmaster doc improv
Date
Msg-id 15577.1080017695@sss.pgh.pa.us
Whole thread Raw
In response to charset / postmaster doc improv  (Neil Conway <neilc@samurai.com>)
Responses Re: charset / postmaster doc improv
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> I've applied the attached patch to CVS HEAD. It improves the
> postmaster reference page, the locale / character set docs, adds some
> more cross-references to the locale / character set docs, and makes a
> few minor fixes elsewhere. Any suggestions for future improvement are
> welcome.

Looks good ... one trivial quibble:

> !         This option is equivalent to setting <literal>listen_addresses</> in
> !         <filename>postgresql.conf</>.
> --- 171,185 ----
> !         Specifying this option is equivalent to setting the <xref
> !         linkend="guc-listen-addresses">.

"... setting the listen_addresses" seems a bit too brief to me; in a
medium that doesn't mark up the crossref at all, it'd seem disconnected.
I'd have written at least "the <xref linkend="guc-listen-addresses">
configuration parameter".

Just MHO though, others might see it differently.

            regards, tom lane

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: charset / postmaster doc improv
Next
From: Bruce Momjian
Date:
Subject: Fix for fseeko.c and pg_dump -Ft