Postgres Pro
Downloads
Home   >   mailing lists

Re: Re: popen and pclose redefinitions causing many warning in Windows build - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Re: popen and pclose redefinitions causing many warning in Windows build
Date
Msg-id 15514.1401157470@sss.pgh.pa.us
Whole thread Raw
In response to Re: Re: popen and pclose redefinitions causing many warning in Windows build  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view 
Michael Paquier <michael.paquier@gmail.com> writes:
> On Tue, May 27, 2014 at 1:39 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The best alternative I can think of is to use strncmp() to check for
>> whether the head of the string matches "COPY ", and then perform the
>> integer conversion using strtoull() #ifdef HAVE_STRTOULL and strtoul()
>> otherwise.

> What about the attached?

Looks good to me --- pushed.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Re: popen and pclose redefinitions causing many warning in Windows build
Next
From: Shigeru Hanada
Date:
Subject: Re: postgres_fdw and connection management