Re: backtrace_on_internal_error - Mailing list pgsql-hackers

From Tom Lane
Subject Re: backtrace_on_internal_error
Date
Msg-id 1551183.1702074926@sss.pgh.pa.us
Whole thread Raw
In response to Re: backtrace_on_internal_error  (Andres Freund <andres@anarazel.de>)
Responses Re: backtrace_on_internal_error
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> I thought it'd be nice to have a test for this, particularly because it's not
> clear that the behaviour is consistent across openssl versions.

Perhaps, but ...

> To deal with that, I changed the test to instead check if "not accept SSL
> connection: Success" is not logged.

... testing only that much seems entirely not worth the cycles, given the
shape of the patches we both just made.  If we can't rely on "errno != 0"
to ensure we won't get "Success", there is one heck of a lot of other
code that will be broken worse than this.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: backtrace_on_internal_error
Next
From: Tom Lane
Date:
Subject: Re: micro-optimizing json.c