Re: proposal: rounding up time value less than its unit. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: proposal: rounding up time value less than its unit.
Date
Msg-id 15325.1408634199@sss.pgh.pa.us
Whole thread Raw
In response to Re: proposal: rounding up time value less than its unit.  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Responses Re: proposal: rounding up time value less than its unit.
List pgsql-hackers
Heikki Linnakangas <hlinnakangas@vmware.com> writes:
> The patch also rounds a zero up to one. A naked zero with no unit is not 
> affected, but e.g if you have "log_rotation_age=0s", it will not disable 
> the feature as you might expect, but set it to 1 minute. Should we do 
> something about that?

That sounds like a dealbreaker to me.  There are enough places where zero
has special meaning that we should not *ever* change zero to non-zero
silently.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Hardening pg_upgrade
Next
From: "Baker, Keith [OCDUS Non-J&J]"
Date:
Subject: Re: Proposal to add a QNX 6.5 port to PostgreSQL