Re: Make SPI_prepare argtypes argument const - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Make SPI_prepare argtypes argument const
Date
Msg-id 1532419.1781182610@sss.pgh.pa.us
Whole thread
In response to Make SPI_prepare argtypes argument const  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> This changes the argtypes argument of SPI_prepare(),
> SPI_prepare_cursor(), SPI_cursor_open_with_args(), and
> SPI_execute_with_args() from Oid *argtypes to const Oid *argtypes.

We've discussed that before, and held off because we weren't entirely
sure if anyone would complain that it is an API/ABI break.  I think
it's quite likely that the libabigail buildfarm machines will say
it is, but is there any actual consequence?

Also, if we are going to use const in SPI, there are more parameters
besides the datatype OIDs that could stand to be const-ified, eg
the various Datum/isnull arrays.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Fix race in ReplicationSlotRelease for ephemeral slots
Next
From: Marcos Pegoraro
Date:
Subject: Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements