Re: Fwd: [TESTERS] [PostgreSQL 9.1 alpha5] OpenBSD and Loongson - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fwd: [TESTERS] [PostgreSQL 9.1 alpha5] OpenBSD and Loongson
Date
Msg-id 15234.1302194273@sss.pgh.pa.us
Whole thread Raw
In response to Fwd: [TESTERS] [PostgreSQL 9.1 alpha5] OpenBSD and Loongson  (Josh Berkus <josh@agliodbs.com>)
List pgsql-hackers
Josh Berkus <josh@agliodbs.com> writes:
> I need the following patch to make PostgreSQL happy
> on Loongson with OpenBSD (http://www.openbsd.org/loongson.html).
> These restrictions no longer exist on OpenBSD.
> Tested with the latest alpha (9.1 alpha5) and with
> the latest 9 release (9.0.3).

I'm a bit inclined to think the right fix is not exactly what is
proposed here, but rather to make the openbsd (and freebsd) versions of
this file look like the netbsd one, viz

#if !defined(HAVE_DLOPEN)snprintf(error_message, sizeof(error_message),         "dlopen (%s) not supported",
file);returnNULL;
 
#else

Since you can't do much useful without dlopen support in any modern
version of Postgres, it doesn't seem like there is much risk of breaking
any working situation --- so we might as well back-patch, too.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: pg_upgrade bug found!
Next
From: Selena Deckelmann
Date:
Subject: Headcount for PL Summit, Saturday May 21, 2011 at PgCon