Re: pg_basebackup: Missing newlines in some error messages - Mailing list pgsql-hackers

From Michael Banck
Subject Re: pg_basebackup: Missing newlines in some error messages
Date
Msg-id 1521637132.15036.9.camel@credativ.de
Whole thread Raw
In response to Re: pg_basebackup: Missing newlines in some error messages  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pg_basebackup: Missing newlines in some error messages  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Hi,

Am Mittwoch, den 21.03.2018, 09:54 -0300 schrieb Alvaro Herrera:
> Michael Banck wrote:
> > I apparently managed to screw up so badly that no PQerrorMessage was
> > set, so saw the above (which indeed has no error message after the
> > colon).
> 
> Well, maybe that's a different bug, then: maybe we should print
> something other than PQerrorMessage (or maybe PQerrorMessage should not
> return empty!).  Can you reproduce the problem?

It was while I was hacking on the code and mistyped something, so I
think this is entirely my fault and not a valid concern. From what I
could tell, I got PGRES_FATAL_ERROR back (I printed the int value, which
was 7), so that could explain why there was no PQerrorMessage?


Michael

-- 
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax:  +49 2166 9901-100
Email: michael.banck@credativ.de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pg_basebackup: Missing newlines in some error messages
Next
From: Michael Banck
Date:
Subject: pg_basebackup: Allow setting replication slots in recovery.confeven if wal-method is none