Re: pgindent (Re: [HACKERS] LONG varsize - how to go on) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent (Re: [HACKERS] LONG varsize - how to go on)
Date
Msg-id 1520.945555247@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent (Re: [HACKERS] LONG varsize - how to go on)t  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Again, I think everyone liked it at the time, but this may have changed.
>
> Speak up, folks.

I can live with the code layout conventions we have in place; I like K&R
layout better, but not enough to fight about it.  It's easy enough to
set up Emacs to handle the style we have.

What I do *not* like is the tab-stops-are-4-spaces convention.  As Peter
says, that makes the code look horrible in any tool that can't easily be
adjusted to a nonstandard tab spacing.

My preference would be to use standard 8-space meaning of tabs, but
stick with our current conventions for visible layout of code (4 columns
per logical indent level, etc).  That means people contributing code
would need to use editors that understand the difference between a
physical tab character and a logical indent level.  I get the impression
that a number of key developers don't use such editors, so maybe
switching over isn't going to be practical.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Anyone for prettyprinted EXPLAIN VERBOSE?
Next
From: Brook Milligan
Date:
Subject: Re: [HACKERS] Re: [PATCHES] Lock