Re: Caution when removing git branches - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Caution when removing git branches
Date
Msg-id 15182.1296145764@sss.pgh.pa.us
Whole thread Raw
In response to Re: Caution when removing git branches  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Caution when removing git branches  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Wed, Jan 26, 2011 at 17:37, Andrew Dunstan <andrew@dunslane.net> wrote:
>> I thought we had some hooks on gitmaster to help prevent accidents like
>> inadvertent branch deletion.

> We have hooks to prevent a number of things, but not the removal of
> branches (or tags). We'll send an email to committers telling you it's
> been done, but we don't prevent it.

> It would probably be pretty easy to add a hook preventing it though -
> do we want that? (we could still delete branches of course - but it
> would require an admin to do it directly on the git server, which is
> highly unlikely to happen by mistake)

Given that nobody is supposed to push temporary branches to the master
repo anyway, an intended branch removal should be a pretty darn rare
event.  Now, our committers all seem to be pretty careful people, so
I don't feel strongly about having extra security on this --- but if
it's easy to do, it's probably a good idea.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Caution when removing git branches
Next
From: Bruce Momjian
Date:
Subject: Re: Re: In pg_test_fsync, use K(1024) rather than k(1000) for write size units.