Re: HOT is applied - Mailing list pgsql-hackers

From Tom Lane
Subject Re: HOT is applied
Date
Msg-id 15120.1190401222@sss.pgh.pa.us
Whole thread Raw
In response to Re: HOT is applied  ("Heikki Linnakangas" <heikki@enterprisedb.com>)
List pgsql-hackers
"Heikki Linnakangas" <heikki@enterprisedb.com> writes:
> I noted that most callers of TransactionIdIsInProgress in tqual.c
> already call TransactionIdIsCurrentTransactionId before
> TransactionIdIsInProgress. In those cases we could just skip the test
> for our own xids altogether, if it's worth code mangling to tell
> TransactionIdIsInProgress whether it's safe to skip it or not.

At least in this example, it seems it wouldn't buy anything.
HeapTupleSatisfiesVacuum doesn't call
TransactionIdIsCurrentTransactionId, and while HeapTupleSatisfiesMVCC
does, it falls out at that point and doesn't get to
TransactionIdIsInProgress.  So I'm not inclined to contort the API
unless we can come up with an example where it's important.

I'm off to work on the page-header-xid idea ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Brendan Jurd"
Date:
Subject: Text <-> C string
Next
From: Gregory Stark
Date:
Subject: Re: Text <-> C string