Re: pgindent exit status if a file encounters an error - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent exit status if a file encounters an error
Date
Msg-id 1510956.1719415478@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent exit status if a file encounters an error  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
Responses Re: pgindent exit status if a file encounters an error
List pgsql-hackers
Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> writes:
> The usage help mentions exit code 2 specifically while describing --check
> option but it doesn't mention exit code 1. Neither does the README. So I
> don't think we need to document exit code 3 anywhere. Please let me know if
> you think otherwise.

I think we should have at least a code comment summarizing the
possible exit codes, along the lines of

# Exit codes:
#   0 -- all OK
#   1 -- could not invoke pgindent, nothing done
#   2 -- --check mode and at least one file requires changes
#   3 -- pgindent failed on at least one file

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrei Lepikhov
Date:
Subject: Incremental Sort Cost Estimation Instability
Next
From: Nathan Bossart
Date:
Subject: Re: [PATCH] Add ACL (Access Control List) acronym