Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug - Mailing list pgsql-bugs

From Jan Przemysław Wójcik
Subject Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug
Date
Msg-id 1510059095836-0.post@n3.nabble.com
Whole thread Raw
In response to Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Responses Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-bugs
Hi,

my statement about the function usefulness was probably too categorical,
though I had in mind the current name of the function.

I'm afraid that creating a function that implements quite different
algorithms depending on a global parameter seems very hacky and would lead
to misunderstandings. I do understand the need of backward compatibility,
but I'd opt for the lesser evil. Perhaps a good idea would be to change the
name to 'substring_similarity()' and introduce the new function
'word_similarity()' later, for example in the next major version release.

------
Jan Przemysław Wójcik



--
Sent from: http://www.postgresql-archive.org/PostgreSQL-bugs-f2117394.html


--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

pgsql-bugs by date:

Previous
From: Yan Maystrenko
Date:
Subject: [BUGS] Returning same row twice in certain conditions
Next
From: sean.johnston@edgeintelligence.com
Date:
Subject: [BUGS] BUG #14890: Error grouping by same column twice using FDW