Re: Remove toast_max_chunk_size from control file - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove toast_max_chunk_size from control file
Date
Msg-id 150388.1788745413@sss.pgh.pa.us
Whole thread
Responses Re: remove WaitEventCustomCounterData
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> Requoting my previous message that you did not include:

>> There may be an argument about somebody enforcing a new
>> TOAST_OID_MAX_CHUNK_SIZE or EXTERN_TUPLES_PER_PAGE manually, of
>> course, but while we claim that tweaks are possible in heaptoast.h,

> I've never seen anybody actually do that.  So yes, I agree that if
> somebody has the idea to change this value manually, the control file
> value makes sense to keep.  It's just that I doubt that anybody is
> actually doing that.  :)

Perhaps not, but the point of these disk-layout-compatibility fields
in pg_control is to keep people from shooting themselves in the foot.
I don't think it's that unlikely that someone would decide that four
TOAST tuples per page isn't ideal, especially if they were running
with non-default BLCKSZ.

            regards, tom lane



Attachment

pgsql-hackers by date:

Previous
From: Zsolt Parragi
Date:
Subject: Improve error handling in test modules: test_extensible, test_bitmapset
Next
From: Chao Li
Date:
Subject: Re: [DOC] pg_database_size/pg_tablespace_size error on a missing OID