Re: set_rel_pathlist function unnecessary params. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: set_rel_pathlist function unnecessary params.
Date
Msg-id 1500220.1727726182@sss.pgh.pa.us
Whole thread Raw
In response to set_rel_pathlist function unnecessary params.  (Kirill Reshke <reshkekirill@gmail.com>)
List pgsql-hackers
Kirill Reshke <reshkekirill@gmail.com> writes:
> I happened to notice that `set_rel_pathlist` params, RelOptInfo *rel
> and RangeTblEntry *rte are
> unnecessary, because upon all usages,
> `rte=root->simple_rte_array[rti]` and
> `rel=root->simple_rel_array[rti]` holds. What's the point of providing
> the same information 3 times?

To avoid having to re-fetch it from those arrays?

> So, I propose to refactor this a little bit.
> Am I missing something?

I'm -1 on changing this.  It'd provide no detectable benefit
while creating back-patching hazards in this code.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Kirill Reshke
Date:
Subject: set_rel_pathlist function unnecessary params.
Next
From: Robert Haas
Date:
Subject: Re: pg_verifybackup: TAR format backup verification