Re: Reduce lock levels for ADD and DROP COLUMN - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Reduce lock levels for ADD and DROP COLUMN
Date
Msg-id 14952.1293464515@sss.pgh.pa.us
Whole thread Raw
In response to Re: Reduce lock levels for ADD and DROP COLUMN  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Reduce lock levels for ADD and DROP COLUMN  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Dec 27, 2010 at 6:42 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
>> Idea is to reduce lock level of ADD/DROP COLUMN from AccessExclusiveLock
>> down to ShareRowExclusiveLock.
>> 
>> To make it work, we need to recognise that we are adding a column
>> without rewriting the table.

> Can you elaborate on why you think that's the right test?  It seems to
> me there could be code out there that assumes that the tuple
> descriptor won't change under it while it holds an AccessShareLock.

s/could/definitely is/

I think this is guaranteed to break stuff; to the point that I'm
not even going to review the proposal in any detail.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Streaming replication as a separate permissions
Next
From: Simon Riggs
Date:
Subject: Re: Streaming replication as a separate permissions