Re: [HACKERS] [patch] reorder tablespaces in basebackup tar streamfor backup_label - Mailing list pgsql-hackers

From Bernd Helmle
Subject Re: [HACKERS] [patch] reorder tablespaces in basebackup tar streamfor backup_label
Date
Msg-id 1488557586.24682.17.camel@oopsware.de
Whole thread Raw
In response to Re: [HACKERS] [patch] reorder tablespaces in basebackup tar streamfor backup_label  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] [patch] reorder tablespaces in basebackup tar streamfor backup_label  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Am Freitag, den 03.03.2017, 15:44 +0900 schrieb Michael Paquier:
> So, the main directory is located at the end on purpose. When using
> --wal-method=fetch the WAL segments are part of the main tarball, so
> if you send the main tarball first you would need to generate a
> second
> tarball with the WAL segments that have been generated between the
> moment the main tarball has finished until the end of the last
> tablespace taken if you want to have a consistent backup. Your patch
> would work with the stream mode though.

Ah right, i assumed there must be something, otherwise the comment
won't be there ;)

We could special case that part to distinguish fetch/stream mode, but i
fear that leads to more confusion than it wants to fix. The other
option of a separate tar file looks awkward from a usability point of
view.



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [HACKERS] pg_upgrade loses security lables and COMMENTs on blobs
Next
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] GUC for cleanup indexes threshold.