Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting forcheckpoint - Mailing list pgsql-hackers

From Michael Banck
Subject Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting forcheckpoint
Date
Msg-id 1488142426.24065.10.camel@credativ.de
Whole thread Raw
In response to Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint
List pgsql-hackers
Hi,

Am Sonntag, den 26.02.2017, 21:32 +0100 schrieb Magnus Hagander:

> On Sun, Feb 26, 2017 at 8:27 PM, Michael Banck
> <michael.banck@credativ.de> wrote:

> Agreed, and applied as one patch. Except I noticed you also fixed a
> couple of entries which were missing the progname in the messages -- I
> broke those out to a separate patch instead.

Thanks!

> Made a small change to "using as much I/O as available" rather than
> "as possible", which I think is a better wording, along with the
> change of the idle wording I suggested before. (but feel free to point
> it out to me if that's wrong). 

LGTM, I apparently missed your suggestion when I re-read the thread.

I am just wondering whether this could/should be back-patched, maybe? It
is not a bug fix, of course, but OTOH is rather small and probably
helpful to some users on current releases.


Michael

-- 
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax:  +49 2166 9901-100
Email: michael.banck@credativ.de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer





pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint
Next
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint