Re: [COMMITTERS] pgsql: Fix assorted portability issues in new pgbench TAP tests. - Mailing list pgsql-committers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Fix assorted portability issues in new pgbench TAP tests.
Date
Msg-id 14833.1504892746@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Fix assorted portability issues in newpgbench TAP tests.  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-committers
Fabien COELHO <coelho@cri.ensmp.fr> writes:
> Please find attached "blind" additional fixes for Windows & AIX.

>   - more nan/inf variants

I think we should just drop this.  It's not worth the trouble,
and I have no faith whatsoever that we've seen every behavior.

>   - different message on non existing user

Ditto.  It's not only not worth the trouble, it's out of scope for
pgbench tests.  A single connection-failure test case seems plenty
to me, and the no-such-database case is enough for that.

> I suspect that $windows_os is not true on "bowerbird", in order to fix it 
> the value of "$Config{osname}" is needed...

I looked at sub psql and noted that it was disassembling the $? result
without any platform-specific hacks.  So I've made command_checks_all
do likewise, and also notice crashes if any.
        regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.