Re: [pgsql-pkg-yum] When %nls/%ssl/%xml macro is set to 0 - Mailing list pgsql-pkg-yum

Hi,

Thanks for the patch. Committed:

https://git.postgresql.org/gitweb/?p=pgrpms.git;a=commit;h=b7811829fdbf46b0248f8f0f1c3ca471616b7e04

Regards, Devrim

On Thu, 2016-11-03 at 21:35 +0900, Tomoaki Sato wrote:
> Hi,
>
> When %nls macro is set to 0, PostgreSQL 9.6 RPM package build fails.
>
> ---
> $ rpmbuild -ba -D 'nls 0' SPECS/postgresql-9.6.spec 
> (snip)
> + /usr/bin/cp /dev/null pltcl.lst
> + /usr/bin/cp /dev/null plpython.lst
> + cat libpq5-9.6.lang
> cat: libpq5-9.6.lang: No such file or directory
> error: Bad exit status from /var/tmp/rpm-tmp.ct9Vwi (%install)
>
>
> RPM build errors:
>     Bad exit status from /var/tmp/rpm-tmp.ct9Vwi (%install)
> ----
>
> *.lst filename and %endif position for %if %{nls} ... %endif block are
> wrong.
>
> Even when %ssl macro is set to 0, it fails.
>
> ----
> $ rpmbuild -ba -D 'ssl 0' SPECS/postgresql-9.6.spec
> + cp -pr src/tutorial /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-
> 1PGDG.el7.centos.x86_64/usr/share/doc/postgresql96-docs-9.6.1
> + cp -pr doc/html /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-
> 1PGDG.el7.centos.x86_64/usr/share/doc/postgresql96-docs-9.6.1
> + exit 0
> Provides: postgresql-docs postgresql96-docs = 9.6.1-1PGDG.el7.centos
> postgresql96-docs(x86-64) = 9.6.1-1PGDG.el7.centos
> Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests)
> <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
> Requires: /bin/sh libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) rtld(GNU_HASH)
> Processing files: postgresql96-contrib-9.6.1-1PGDG.el7.centos.x86_64
> error: File not found: /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-
> 1PGDG.el7.centos.x86_64/usr/pgsql-9.6/lib/sslinfo.so
> error: File not found by glob: /home/tom-
> sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-1PGDG.el7.centos.x86_64/usr/pgsql-
> 9.6/share/extension/sslinfo*
>
>
> RPM build errors:
>     File not found: /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-
> 1PGDG.el7.centos.x86_64/usr/pgsql-9.6/lib/sslinfo.so
>     File not found by glob: /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-
> 9.6.1-1PGDG.el7.centos.x86_64/usr/pgsql-9.6/share/extension/sslinfo*
> ----    
>
> sslinfo module isn't excluded from %files list. 
>
> Even when %xml macro is set to 0, it fails.
>
> ----
> $ rpmbuild -ba -D 'xml 0' SPECS/postgresql-9.6.spec
> + cp -pr src/tutorial /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-
> 1PGDG.el7.centos.x86_64/usr/share/doc/postgresql96-docs-9.6.1
> + cp -pr doc/html /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-
> 1PGDG.el7.centos.x86_64/usr/share/doc/postgresql96-docs-9.6.1
> + exit 0
> Provides: postgresql-docs postgresql96-docs = 9.6.1-1PGDG.el7.centos
> postgresql96-docs(x86-64) = 9.6.1-1PGDG.el7.centos
> Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests)
> <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
> Requires: /bin/sh libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) rtld(GNU_HASH)
> Processing files: postgresql96-contrib-9.6.1-1PGDG.el7.centos.x86_64
> error: File not found by glob: /home/tom-
> sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-1PGDG.el7.centos.x86_64/usr/pgsql-
> 9.6/share/extension/xml2*
>
>
> RPM build errors:
>     File not found by glob: /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-
> 9.6.1-1PGDG.el7.centos.x86_64/usr/pgsql-9.6/share/extension/xml2*
> ----
>
> xml2 module isn't excluded from %files list. 
>
> Send a patch to fix them.
>
> Regards,
>
>
> ----
> Tomoaki Sato <sato@sraoss.co.jp>
> SRA OSS, Inc. Japan

--
Devrim GÜNDÜZ
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR