Re: Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization) - Mailing list pgsql-committers

From Tom Lane
Subject Re: Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)
Date
Msg-id 14802.1439219996@sss.pgh.pa.us
Whole thread Raw
In response to Re: Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)  (Christoph Berg <myon@debian.org>)
Responses Re: Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Christoph Berg <myon@debian.org> writes:
> Thanks, the build worked now.

> Wouldn't a possible fix be to promote this/some module to core? It
> doesn't have any SQL- or OS-side dependencies.

Meh.  I think we'd agreed in another nearby thread that pageinspect
is exactly the sort of thing we don't want in core.  Even if it were
in core, I'm dubious that it's a good way to implement the desired
testing here: the risks of platform-dependent results (endianness,
varying numbers of tuples per page, etc etc) seem far too high.

            regards, tom lane


pgsql-committers by date:

Previous
From: Christoph Berg
Date:
Subject: Re: Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Temporarily(?) remove BRIN isolation test.