Re: Fix misaligned access of ItemPointerData on ARM - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix misaligned access of ItemPointerData on ARM
Date
Msg-id 14761.1432243377@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix misaligned access of ItemPointerData on ARM  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2015-05-21 16:49:27 -0400, Tom Lane wrote:
>> I considered also adding a Static_assert about sizeof(ItemIdData),
>> but I'm afraid that compilers that don't support these pragmas
>> probably don't support Static_assert either, so it's not clear
>> that that would catch anything.

> I think your fallback for static assert should pretty much always work?
> With an ugly message, but work nonetheless?

Good point.  Committed with a static assertion.  We shall now retire
to a safe distance and watch the buildfarm.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Fix misaligned access of ItemPointerData on ARM
Next
From: Tom Lane
Date:
Subject: Re: GiST KNN Crasher