Re: pg_dump Add dumping of comments on index columns - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_dump Add dumping of comments on index columns
Date
Msg-id 14646.1248390165@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_dump Add dumping of comments on index columns  (Brendan Jurd <direvus@gmail.com>)
Responses Re: pg_dump Add dumping of comments on index columns
List pgsql-hackers
Brendan Jurd <direvus@gmail.com> writes:
> I've also done an initial review of the patch.  Everything looks sane
> and the patch works as advertised.  I made a couple of minor tweaks
> for code-style and comment consistency, and my version 3 is attached.

> I'm marking this patch Ready for Committer.

Applied with minor revisions --- mostly, it leaked memory in the case
of no comments, and the query wasn't very schema-safe.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: join regression failure on cygwin
Next
From: Tom Lane
Date:
Subject: Re: join regression failure on cygwin