Re: pgindent run? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent run?
Date
Msg-id 14628.1516822447@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent run?  (Andres Freund <andres@anarazel.de>)
Responses Re: pgindent run?
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> FWIW, I think this problem could just as well be addressed with a few
> printing heuristics instead of actually needing an actual list of
> typedefs.

Step right up and implement that, and we'd all be happier.  Certainly
the typedefs list is a pain in the rear.

> There'd be one or two edge cases of bad formatting, but the
> end result would be far less painful than what we have today, were
> basically nobody can format their patches without a lot of manual
> cherry-picking or large scale unrelated whitespace changes.

IMO, the big problem here is that people commit large changes without
having pgindent'd them first.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Add parallel-aware hash joins.
Next
From: Andres Freund
Date:
Subject: Re: pgindent run?