Re: [PATCH] vacuum: stop using stream ring after failsafe - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] vacuum: stop using stream ring after failsafe
Date
Msg-id 1460393.1786053857@sss.pgh.pa.us
Whole thread
In response to [PATCH] vacuum: stop using stream ring after failsafe  (Jingtang Zhang <mrdrivingduck@gmail.com>)
List pgsql-hackers
Melanie Plageman <melanieplageman@gmail.com> writes:
> Okay, I pushed it, but right after pushing it I suddenly had the
> thought, omg, it loops through all the ReadBuffersOperations and sets
> them to NULL for _every_ page after entering failsafe mode. And we
> obviously ought to fix that. Proposed patch to do that with a simple
> local variable is attached. This time I'll let this one sit for longer
> before pushing to avoid mistakes like last time.

Don't wait too long, unless you want to revert 112c26838 et al
till after the upcoming releases.  As things stand right now,
we'd ship what is in git.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: [PATCH] vacuum: stop using stream ring after failsafe
Next
From: Michael Paquier
Date:
Subject: Re: Credits For v19