Do we still need gen_node_support.pl's nodetag ABI stability check? - Mailing list pgsql-hackers

From Tom Lane
Subject Do we still need gen_node_support.pl's nodetag ABI stability check?
Date
Msg-id 1458883.1776143073@sss.pgh.pa.us
Whole thread
Responses Re: Do we still need gen_node_support.pl's nodetag ABI stability check?
Re: Do we still need gen_node_support.pl's nodetag ABI stability check?
List pgsql-hackers
We're still a couple months away from cutting the REL_19_STABLE
branch, but I was contemplating that just now, and it occurred to me
to wonder whether we still need gen_node_support.pl's single-purpose
ABI check (cf commit eea9fa9b2) now that we have buildfarm animals
running general-purpose ABI stability checks.

On the one hand, there's much to be said for belt-and-suspenders-too
safety checks.  On the other hand, updating gen_node_support.pl is
an extra manual step while creating a branch, so it's easy to forget
or get wrong.  It's also not very clear why this particular sort
of ABI break in a stable branch is any worse than other hazards.

I'm not really set either way, but my first thought is to drop
the special mechanism.

            regards, tom lane



pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Improve logical replication usability when tables lack primary keys
Next
From: David Rowley
Date:
Subject: Re: POC: Comparison of partitioning key values