Re: [PATCH] sh: Add support Renesas SuperH - Mailing list pgsql-patches

From Tom Lane
Subject Re: [PATCH] sh: Add support Renesas SuperH
Date
Msg-id 14537.1207411101@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] sh: Add support Renesas SuperH  (Nobuhiro Iwamatsu <iwamatsu@nigauri.org>)
List pgsql-patches
Nobuhiro Iwamatsu <iwamatsu@nigauri.org> writes:
> +    __asm__ __volatile__(
> +        "tas.b  @%1\n\t"
> +        "movt   %0\n\t"
> +        "xor    #1,%0"
> +:        "=z"(_res)
> +:        "r"(lock)
> +:        "t","memory");

Another question: this asm declaration ignores the advice given at lines
89-107 of s_lock.h, both cosmetic and substantive.  Why?  Are you
entirely certain it's right, and not subject to optimization problems in
versions of gcc other than whatever you tested?

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] sh: Add support Renesas SuperH
Next
From: Alvaro Herrera
Date:
Subject: Re: Expose checkpoint start/finish times into SQL.