Re: pgsql: Remove pg_class.relhaspkey - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Remove pg_class.relhaspkey
Date
Msg-id 1452.1521067003@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Remove pg_class.relhaspkey  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Remove pg_class.relhaspkey  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-committers
Andrew Dunstan <andrew@dunslane.net> writes:
> Basing an MV on pg_class could always be difficult for pg_upgrade. Maybe
> that's not a brilliant thing to do in a test (or maybe the test should drop
> the MV after it's done).

OH.  Is that what it's doing?  The cause of the failure is immediately
obvious then.  pg_class now lacks a relhaspkey column, but the matview
is still dependent on one being there.

I concur that this is not well-considered test design.

            regards, tom lane


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Remove pg_class.relhaspkey
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Remove pg_class.relhaspkey