Re: Guarantee order of batched pg_advisory_xact_lock - Mailing list pgsql-general

From Tom Lane
Subject Re: Guarantee order of batched pg_advisory_xact_lock
Date
Msg-id 14506.1770844674@sss.pgh.pa.us
Whole thread Raw
In response to Guarantee order of batched pg_advisory_xact_lock  (Nico Heller <nico.heller@posteo.de>)
Responses Re: Guarantee order of batched pg_advisory_xact_lock
List pgsql-general
Nico Heller <nico.heller@posteo.de> writes:
> We use the following bulk query as we sometimes need acquire multiple 
> locks at the same time and want to avoid round-trips to the database:

>     |WITH keys(key) AS (SELECT unnest(:keysToLock)) SELECT
>     pg_advisory_xact_lock(hashtextextended(key, 0)) FROM keys|

> :keysToLock is a text[] parameter which is pre-sorted in our 
> application. This pre-sorting is done to prevent dead locks when two 
> concurrent transactions try acquire the same advisory locks (e.g. 
> [a,b,c] [b,a,c] can easily deadlock).
> We thought this would be enough, but we occasionally still run into 
> deadlocks.

Have you eliminated the possibility that you're getting hash
collisions?  With or without that CTE, I can't see a reason for
PG to change the order in which the unnest() results are processed,
so I think you are barking up the wrong tree about where the
problem is.

            regards, tom lane



pgsql-general by date:

Previous
From: Nico Heller
Date:
Subject: Guarantee order of batched pg_advisory_xact_lock
Next
From: Nico Heller
Date:
Subject: Re: Guarantee order of batched pg_advisory_xact_lock