Request a Demo
Home   >   mailing lists

Re: Improve hash join's handling of tuples with null join keys - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Improve hash join's handling of tuples with null join keys
Date
Msg-id 1449781.1773948276@sss.pgh.pa.us
Whole thread Raw
In response to Re: Improve hash join's handling of tuples with null join keys  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
Tree view 
Chao Li <li.evan.chao@gmail.com> writes:
> Overall, this looks like a solid patch to me.

Thanks for taking another look.

> The only thing I noticed is that while 0002 fixes the tuple-counting issue, there does not seem to be a test that
wouldfail without it. So I think it would be better to add a test case for 0002. I tried doing that and attached a
diff.Without 0002, the test fails; with 0002, it passes. 

I couldn't get excited about expending test cycles on that.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions
Next
From: SATYANARAYANA NARLAPURAM
Date:
Subject: Re: Read-only connection mode for AI workflows.