Re: Typos in the code and README - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Typos in the code and README
Date
Msg-id 1448466.1767650100@sss.pgh.pa.us
Whole thread Raw
In response to Re: Typos in the code and README  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2026-01-05 16:43:02 -0500, Tom Lane wrote:
>> Yeah --- but that was true before too.  I don't quite see how
>> it built under meson before.

> Previously the only thing including snowball/libstemmer/*h files was
> src/backend/snowball/dict_snowball.c, which included them relative to
> src/includ. But now they are also included from
> src/backend/snowball/libstemmer/stem_*.c,

Oh, you're right.  So it worked without any Makefile changes because
the Makefile already had

override CPPFLAGS := -I$(top_srcdir)/src/include/snowball \
    -I$(top_srcdir)/src/include/snowball/libstemmer $(CPPFLAGS)

but meson.build had failed to duplicate that.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Disallow concurrent ALTER DOMAIN and DROP DOMAIN
Next
From: Andres Freund
Date:
Subject: Re: Decouple C++ support in Meson's PGXS from LLVM enablement