Re: pg_bsd_indent - improvements around offsetof and sizeof - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_bsd_indent - improvements around offsetof and sizeof
Date
Msg-id 14447.1464215558@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_bsd_indent - improvements around offsetof and sizeof  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Andres Freund wrote:
>> On 2016-05-25 22:01:53 +0200, Piotr Stefaniak wrote:
>>> On 2016-05-25 21:13, Tom Lane wrote:
>>>> I'd love to see a fix for its brain damage around function pointer typedef formatting, too.

>>> Show me a few examples and I'll look into it.

> See src/include/replication/logical.h; the problem there is pretty
> obvious.

More examples are in, eg, src/include/access/amapi.h.  It's aligning the
additional lines of a multiline function-pointer typedef to *something*,
but it's not very clear what exactly, and in any case it's indenting them
much too far to have any hope of readability.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pg_bsd_indent - improvements around offsetof and sizeof
Next
From: Alvaro Herrera
Date:
Subject: Re: [BUGS] BUG #13473: VACUUM FREEZE mistakenly cancel standby sessions