Re: duplicate function oid symbols - Mailing list pgsql-hackers

From Tom Lane
Subject Re: duplicate function oid symbols
Date
Msg-id 1443774.1603913060@sss.pgh.pa.us
Whole thread Raw
In response to Re: duplicate function oid symbols  (Andres Freund <andres@anarazel.de>)
Responses Re: duplicate function oid symbols  (Andres Freund <andres@anarazel.de>)
Re: duplicate function oid symbols  (John Naylor <john.naylor@enterprisedb.com>)
Re: duplicate function oid symbols  (John Naylor <john.naylor@enterprisedb.com>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2020-10-28 14:49:06 -0400, Tom Lane wrote:
>> Moreover, this clearly shows the
>> effect John mentioned that people have been copying the style of adjacent
>> entries rather than making use of the standard oid_symbol convention like
>> they should --- some of these don't exist in the initial v11 version of
>> pg_type.dat.

> Wonder if it's worth using something like 'backward_compat_oid_symbol'
> and rejecting plain oid_symbol references for pg_type? That'd perhaps be
> less likely to be copied?

Nah.  What I'm imagining is just that pg_type.h contains

#ifdef EXPOSE_TO_CLIENT_CODE

/*
 * Backwards compatibility for ancient random spellings of OID macros.
 * Don't use these macros in new code.
 */
#define CASHOID  MONEYOID
#define LSNOID   PG_LSNOID

#endif

and then the negotiation here is only about whether to make this list
longer.  We don't need to complicate genbki.pl with a new facility.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add important info about ANALYZE after create Functional Index
Next
From: Andres Freund
Date:
Subject: Re: libpq compression