Re: pgsql: Remove check for accept() argument types - Mailing list pgsql-committers

Peter Eisentraut <peter@eisentraut.org> writes:
> Remove check for accept() argument types

Early returns from the buildfarm are

 gaur          | 2021-11-09 16:55:58 | auth.c:3235:17: warning: pointer targets in passing argument 6 of 'recvfrom'
differin signedness 
 gaur          | 2021-11-09 16:55:58 | pqcomm.c:722:9: warning: pointer targets in passing argument 3 of 'accept'
differin signedness 
 gaur          | 2021-11-09 16:55:58 | pqcomm.c:743:6: warning: pointer targets in passing argument 3 of 'getsockname'
differin signedness 
 gaur          | 2021-11-09 16:55:58 | pgstat.c:483:39: warning: pointer targets in passing argument 3 of 'getsockname'
differin signedness 
 gaur          | 2021-11-09 16:55:58 | pgstat.c:630:9: warning: pointer targets in passing argument 5 of 'getsockopt'
differin signedness 
 gaur          | 2021-11-09 16:55:58 | fe-connect.c:2760:11: warning: pointer targets in passing argument 5 of
'getsockopt'differ in signedness 
 gaur          | 2021-11-09 16:55:58 | fe-connect.c:2788:9: warning: pointer targets in passing argument 3 of
'getsockname'differ in signedness 

Right offhand I don't see any other animals complaining.
May I suggest that "unsigned int" would be a better choice
than "int" for socklen_t?

            regards, tom lane