Re: LLVM jit and matview - Mailing list pgsql-hackers

From Tom Lane
Subject Re: LLVM jit and matview
Date
Msg-id 14398.1532559591@sss.pgh.pa.us
Whole thread Raw
In response to Re: LLVM jit and matview  (Andres Freund <andres@anarazel.de>)
Responses Re: LLVM jit and matview  (Andres Freund <andres@anarazel.de>)
Re: LLVM jit and matview  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2018-07-25 18:11:13 -0400, Alvaro Herrera wrote:
>> But what would be the advantage of avoiding the context release inside
>> FreeExecutorState?  It seems pretty appropriate to me to do it there.
>> You could argue that the JIT context is definitely part of the estate
>> being freed.  Just amend the comment, no?

> I agree it's right to do it there.  I think I'm more questioning whether
> there's even a need to adapt the comment, given it's really a local
> memory resource. But I guess I'll just add a 'and ...' after
> "ExprContexts within the EState".

+1.  Clarity is good.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Scariest patch tournament, PostgreSQL 11 edition
Next
From: Andres Freund
Date:
Subject: Re: buildfarm: could not read block 3 in file "base/16384/2662":read only 0 of 8192 bytes