Re: Parsing errors in pg_hba.conf - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Parsing errors in pg_hba.conf
Date
Msg-id 14373.1225110433@sss.pgh.pa.us
Whole thread Raw
In response to Parsing errors in pg_hba.conf  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Parsing errors in pg_hba.conf
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> In a number of places in pg_hba.conf, we don't actually log what goes
> wrong - instead we just goto a label that will log "invalid token \"%s\"".

> Is there any special reason for this, other than the fact that it was
> the easy way out? I think it would be reasonable to for example log
> "hostssl not supported on this platform" instead of that, when USE_SSL
> is not defined, etc.

It would be seriously messy to try to make the parse-error code know
about things like that.  Better would be to keep the GUC variable in
existence always and have an assign hook to throw the error.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Parsing errors in pg_hba.conf
Next
From: Tom Lane
Date:
Subject: Re: Full socket send buffer prevents cancel, timeout