Re: Bogus EXPLAIN results with column aliases for mismatched partitions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Bogus EXPLAIN results with column aliases for mismatched partitions
Date
Msg-id 14353.1575393129@sss.pgh.pa.us
Whole thread Raw
In response to Re: Bogus EXPLAIN results with column aliases for mismatched partitions  (Etsuro Fujita <etsuro.fujita@gmail.com>)
List pgsql-hackers
Etsuro Fujita <etsuro.fujita@gmail.com> writes:
> On Tue, Dec 3, 2019 at 6:45 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Concretely, I'm thinking of the attached (on top of the other patch,
>> which I just pushed).  This agrees exactly with what ExplainTargetRel
>> does for regular scans.

> Thanks for the patch!  (The patch didn't apply to HEAD cleanly,
> though.)  I like consistency, so +1 for the change.

Yeah, 55a1954da probably changed the expected output from what that
has.  I'll clean it up and push.

>> One could make an argument that we should schema-qualify, regardless
>> of the "verbose" flag, if the output format isn't EXPLAIN_FORMAT_TEXT.
>> That would reduce the amount of variability that plan analysis tools
>> have to cope with.  However, ExplainTargetRel itself doesn't provide
>> the schema in non-verbose mode.  Maybe it should, ie we should change
>> it like ...

> Seems like another issue to me.

Agreed.  When/if we change that, we could make this code follow along.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Windows buildfarm members vs. new async-notify isolation test
Next
From: Daniel Gustafsson
Date:
Subject: Setting min/max TLS protocol in clientside libpq