Re: GinPageIs* don't actually return a boolean - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GinPageIs* don't actually return a boolean
Date
Msg-id 14287.1455288467@sss.pgh.pa.us
Whole thread Raw
In response to Re: GinPageIs* don't actually return a boolean  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: GinPageIs* don't actually return a boolean
Re: GinPageIs* don't actually return a boolean
Re: GinPageIs* don't actually return a boolean
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Feb 12, 2016 at 9:39 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Um, no, that does not follow.  The unanswered question here is why,
>> when we *have not* included stdbool.h and *have* typedef'd bool as
>> just plain "char", we would get C99 bool behavior.

> http://www.postgresql.org/message-id/d2106c2d-0f46-4cf9-af27-54f81ef6e20c@postgrespro.ru
> seems to explain what happens pretty clearly.  We #include something
> which #includes something which #includes something which #includes
> <stdbool.h>.  It's not that surprising, is it?

Well, the thing that is scaring me here is allowing a platform-specific
definition of "bool" to be adopted.  If, for example, the compiler
writer decided that that should be int width rather than char width,
all hell would break loose.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: GinPageIs* don't actually return a boolean
Next
From: Andres Freund
Date:
Subject: Re: CustomScan in a larger structure (RE: CustomScan support on readfuncs.c)