Postgres Pro
Downloads
Home   >   mailing lists

Re: [COMMITTERS] pgsql: Add macros wrapping all usage of gcc's __attribute__. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Add macros wrapping all usage of gcc's __attribute__.
Date
Msg-id 14247.1427325066@sss.pgh.pa.us
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Add macros wrapping all usage of gcc's __attribute__.
List pgsql-hackers
Tree view 
Andres Freund <andres@anarazel.de> writes:
> Add macros wrapping all usage of gcc's __attribute__.

I noticed that this commit attached pg_attribute_noreturn not only
to the extern declarations, but to some actual function definitions.
I think this is a bad idea, because it's going to look like heck after
pgindent gets through with it.  Do we actually need decoration on the
function definitions?
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: proposal: plpgsql - Assert statement
Next
From: Michael Paquier
Date:
Subject: Re: Error with index on unlogged table