Re: bufmgr code cleanup - Mailing list pgsql-patches

From Tom Lane
Subject Re: bufmgr code cleanup
Date
Msg-id 14227.1067871625@sss.pgh.pa.us
Whole thread Raw
In response to Re: bufmgr code cleanup  (Jan Wieck <JanWieck@Yahoo.com>)
Responses Re: bufmgr code cleanup  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
Jan Wieck <JanWieck@Yahoo.com> writes:
> Neil Conway wrote:
>> This patch cleans up some of the bufmgr code:

> Can this be held off a little while we're experimenting with
> improvements to the buffer algorithms?

I do not actually agree with the "UnlockAndReleaseBuffer" changes
anyway.  I think this obscures the code by making resource grabbing
and resource releasing code unsymmetrical, not to mention incompatible
with code branches where the unlock and the buffer release can't be
merged because other things are done in between.

As for removing the BM_TRACE code, what's broken about it?  Shouldn't we
be more interested in fixing it than removing it?

            regards, tom lane

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: equal() perf tweak
Next
From: Tom Lane
Date:
Subject: Re: equal() perf tweak