Re: New "single-call SRF" APIs are very confusingly named - Mailing list pgsql-hackers

From Tom Lane
Subject Re: New "single-call SRF" APIs are very confusingly named
Date
Msg-id 1419109.1665783170@sss.pgh.pa.us
Whole thread Raw
In response to Re: New "single-call SRF" APIs are very confusingly named  (Melanie Plageman <melanieplageman@gmail.com>)
List pgsql-hackers
Melanie Plageman <melanieplageman@gmail.com> writes:
> So, while I agree that the "Single" in SetSingleFuncCall() could be
> confusing given the name of ExprSingleResult, I feel like actually all
> of the names are somewhat wrong.

Maybe, but ExprSingleResult et al. have been there for decades and
are certainly embedded in a ton of third-party code.  It's a bit
late to rename them, whether you think they're confusing or not.
Maybe we can get away with changing names introduced in v15, but
even that I'm afraid will get some pushback.

Having said that, I'd probably have used names based on "materialize"
not "single" for what this code is doing.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: New "single-call SRF" APIs are very confusingly named
Next
From: David Christensen
Date:
Subject: [PATCH] comment fixes for delayChkptFlags