Re: compile warnings in CVS - Mailing list pgsql-hackers

From Tom Lane
Subject Re: compile warnings in CVS
Date
Msg-id 14109.1029639055@sss.pgh.pa.us
Whole thread Raw
In response to Re: compile warnings in CVS  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I said:
> Another alternative is
>     char *fmt = "%c";
>     ...
>     strftime(..., fmt, ...);
> which I think will probably defeat gcc's check (haven't tried it
> though).

I tried this, and it did shut up the warning in my local copy of gcc.
So I committed it.

> Does anyone want to argue that %c is actually a bad choice?

This is still open to debate if anyone wants to make the case...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: cvs-tip broken
Next
From: Bruce Momjian
Date:
Subject: Re: Open 7.3 items