Re: GiST support for UUIDs - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GiST support for UUIDs
Date
Msg-id 1407.1480442322@sss.pgh.pa.us
Whole thread Raw
In response to Re: GiST support for UUIDs  (Chris Bandy <bandy.chris@gmail.com>)
Responses Re: GiST support for UUIDs  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Chris Bandy <bandy.chris@gmail.com> writes:
> [ btree_gist_uuid_8.patch ]

Um ... is there a reason why the penalty logic in gbt_uuid_penalty()
is completely unlike that for any other btree_gist module?

As best I can tell from the (admittedly documentation-free) code
elsewhere, the penalty ought to be proportional to the fraction
by which the original range is expanded; that's not what this
code is doing.  It also seems to be missing the machinations related
to scaling per-column results in a multi-column index.

I'm kind of inclined to change uuid_parts_distance to just convert
a given pg_uuid_t to "double" and then apply penalty_num(), as is
done in gbt_macad_penalty.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: Time to up bgwriter_lru_maxpages?
Next
From: Robert Haas
Date:
Subject: Re: Improving RLS planning