Re: [HACKERS] Timing-sensitive case in src/test/recovery TAP tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Timing-sensitive case in src/test/recovery TAP tests
Date
Msg-id 14061.1498502642@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Timing-sensitive case in src/test/recovery TAP tests  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] Timing-sensitive case in src/test/recovery TAP tests  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> On Mon, Jun 26, 2017 at 12:12 PM, Craig Ringer <craig@2ndquadrant.com> wrote:
>> I'm not sure I understand this.

> The patch attached may explain that better. Your patch added 3 poll
> phases. I think that a 4th is needed. At the same time I have found
> cleaner to put the poll calls into a small wrapper.

Looks good as far as it goes, but I wonder whether any of the other
get_slot_xmins calls need polling too.  Don't feel a need to add such
calls until someone exhibits a failure there, but I won't be very
surprised if someone does.

Anyway, pushed this patch with minor editing.  Thanks!
        regards, tom lane



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: [HACKERS] Another reason why the recovery tests take a long time
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Reducing pg_ctl's reaction time