Re: Summary function for pg_buffercache - Mailing list pgsql-hackers

From Zhang Mingli
Subject Re: Summary function for pg_buffercache
Date
Msg-id 13e3e68a-8266-402e-93c2-5e126c40cc74@Spark
Whole thread Raw
In response to Re: Summary function for pg_buffercache  (Melih Mutlu <m.melihmutlu@gmail.com>)
Responses Re: Summary function for pg_buffercache
List pgsql-hackers
Hi,

On Sep 28, 2022, 22:41 +0800, Melih Mutlu <m.melihmutlu@gmail.com>, wrote:


Zhang Mingli <zmlpostgres@gmail.com>, 28 Eyl 2022 Çar, 17:31 tarihinde şunu yazdı:
Why compute usagecount_avg twice? 

I should have removed the first one, but I think I missed it.
Nice catch.

Attached an updated version.

Thanks,
Melih

Hmm, I just apply v13 patch but failed.

Part of errors:
```
error: patch failed: contrib/pg_buffercache/pg_buffercache.control:1 error: contrib/pg_buffercache/pg_buffercache.control: patch does not apply
Checking patch contrib/pg_buffercache/pg_buffercache_pages.c...
error: while searching for:
 */
PG_FUNCTION_INFO_V1(pg_buffercache_pages);
PG_FUNCTION_INFO_V1(pg_buffercache_pages_v1_4);
```

Rebase on master and then apply our changes again?

Regards,
Zhang Mingli

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: DROP OWNED BY is broken on master branch.
Next
From: Kaiting Chen
Date:
Subject: Re: Allow foreign keys to reference a superset of unique columns